Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote_storage: less sensitive timeout logging in ABS listings #10518

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

jcsp
Copy link
Collaborator

@jcsp jcsp commented Jan 27, 2025

Problem

We were logging a warning after a single request timeout, while listing objects.

Closes: #10166

Summary of changes

  • These timeouts are a pretty normal part of life, so back it off to only log a warning after two in a row.

@jcsp jcsp added a/tech_debt Area: related to tech debt c/storage/scrubber Component: s3_scrubber labels Jan 27, 2025
@jcsp jcsp requested a review from a team as a code owner January 27, 2025 15:56
@jcsp jcsp requested a review from skyzh January 27, 2025 15:56
Copy link

github-actions bot commented Jan 27, 2025

7429 tests run: 7043 passed, 0 failed, 386 skipped (full report)


Flaky tests (3)

Postgres 17

Code coverage* (full report)

  • functions: 33.5% (8497 of 25347 functions)
  • lines: 49.3% (71490 of 145076 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
e236ae9 at 2025-01-27T17:19:29.656Z :recycle:

@jcsp jcsp added this pull request to the merge queue Jan 27, 2025
Merged via the queue into main with commit ebf4421 Jan 27, 2025
90 checks passed
@jcsp jcsp deleted the jcsp/issue-10166-abs-timeouts branch January 27, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/tech_debt Area: related to tech debt c/storage/scrubber Component: s3_scrubber
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scrubber: Azure timeouts
2 participants